On Tue, 2012-11-13 at 14:23 +0200, Vladimir Kondratiev wrote: [] > diff --git a/drivers/net/wireless/ath/wil6210/wil6210.h b/drivers/net/wireless/ath/wil6210/wil6210.h [] > +/* Candidate to merge into printk.h and dynamic_debug.h */ > +#if defined(CONFIG_DYNAMIC_DEBUG) > +#define dynamic_hex_dump(prefix_str, prefix_type, rowsize, \ > + groupsize, buf, len, ascii) \ > +do { \ > + DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, prefix_str); \ > + if (unlikely(descriptor.flags & _DPRINTK_FLAGS_PRINT)) \ > + print_hex_dump(KERN_DEBUG, prefix_str, \ > + prefix_type, rowsize, groupsize, \ > + buf, len, ascii); \ > +} while (0) > + > +#define debug_hex_dump(prefix_str, prefix_type, rowsize, \ > + groupsize, buf, len, ascii) \ > + dynamic_hex_dump(prefix_str, prefix_type,\ > + rowsize, groupsize, buf,\ > + len, ascii) > +#else > +#define debug_hex_dump(prefix_str, prefix_type, rowsize, \ > + groupsize, buf, len, ascii) \ > + print_hex_dump(KERN_DEBUG, prefix_str, \ > + prefix_type, rowsize, \ > + groupsize, buf, len, ascii) > +#endif Thanks Vladimir. I think so too. Jason? Andrew? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html