On Mon, Nov 12, 2012 at 10:31:37AM +0100, Johannes Berg wrote: > On Fri, 2012-11-09 at 17:51 -0800, Bing Zhao wrote: > > From: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > > > wpa_supplicant will do OBSS scan for drivers that implement > > auth/assoc API. Drivers that implement nl80211 connect API > > (rather than auth/assoc) may need wpa_supplicant to do this > > as well. > Applied, but I changed a lot ;-) > > Notably, I reworded the constant name to be > NL80211_FEATURE_NEED_OBSS_SCAN, since we typically use the term > "offload" to mean that the *device* does something, not to mean that > *userspace* does something. Sorry for being a bit late with my comments, but does this single flag really cover expected use cases? I would assume that number of more full MAC -like designs will have to move to separate auth/assoc commands instead of using connect API in the future (e.g., for FT and SAE). However, those drivers do not necessarily expect user space to take care of OBSS scans. I understand that this is not currently supported since wpa_supplicant assuming auth/assoc to mean user space SME, but it should be kept in mind that that may need to change in the future.. I guess we can handle the auth/assoc without user space OBSS scan separately (a new feature flag for stopping OBSS scan?), so I'm fine with this patch moving ahead as-is. -- Jouni Malinen PGP id EFC895FA -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
