Hi Johannes,
> > From: Amitkumar Karwar <akarwar@xxxxxxxxxxx>
> >
> > New flag is added to inform userspace that this driver doesn't
> > internally perform OBSS scan. It can use this feature available
> > in userspace application.
>
> Shouldn't that be a little more precisely worded? Most drivers already
> expect wpa_s to do this, but apparently the assumption was that without
> the flag, full-MAC drivers, i.e. drivers implementing the nl80211
> connect API (rather than auth/assoc) do it themselves?
That's right.
>
> Or maybe mac80211 should just set the flag?
Currently wpa_s checks WPA_DRIVER_FLAGS_SME flag for OBSS scan.
Since WPA_DRIVER_FLAGS_SME bit is set for mac80211, it's unnecessary to set this new flag.
Or, are you suggesting that we should set the new flag in mac80211 (and all drivers that need OBSS scan feature in wpa_s) and replace WPA_DRIVER_FLAGS_SME check with the new flag?
@@ -1031,7 +1031,7 @@ void sme_sched_obss_scan(struct wpa_supplicant *wpa_s, int
if (!enable)
return;
- if (!(wpa_s->drv_flags & WPA_DRIVER_FLAGS_SME) || ssid == NULL ||
+ if (!(wpa_s->drv_flags & WPA_DRIVER_FLAGS_OBSS_SCAN) || ssid == NULL ||
ssid->mode != IEEE80211_MODE_INFRA)
return; /* Not using station SME in wpa_supplicant */
Thanks,
Bing
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
