> @@ -1281,6 +1286,9 @@ enum nl80211_commands {
> *
> * @NL80211_ATTR_SCAN_FLAGS: scan request control flags (u32)
> *
> + * @NL80211_CMD_GET_MESH_STATS: Get mesh networking statistics for the
> + * interface identified by %NL80211_ATTR_IFINDEX
Hmm, what happened here? Should have attribute documentation.
> + err = rdev->ops->get_mesh_stats(&rdev->wiphy, dev, &cur_stats);
Now that we have tracing for cfg80211 calls, could you please add that
here as well?
> + wdev_unlock(wdev);
I don't see a need for the wdev lock, this protects data inside struct
wireless_dev so shouldn't be necessary?
> @@ -7275,6 +7338,14 @@ static struct genl_ops nl80211_ops[] = {
> .flags = GENL_ADMIN_PERM,
> },
> {
> + .cmd = NL80211_CMD_GET_MESH_STATS,
> + .doit = nl80211_get_mesh_stats,
> + .policy = nl80211_policy,
> + /* can be retrieved by unprivileged users */
> + .internal_flags = NL80211_FLAG_NEED_NETDEV_UP |
> + NL80211_FLAG_NEED_RTNL,
> + },
There should probably be advertising that this command is supported, see
send_wiphy's CMD() macro.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
