On Wednesday 31 October 2012 16:14:19 Luis R. Rodriguez wrote: > On Wed, Oct 31, 2012 at 5:57 AM, Vladimir Kondratiev > <qca_vkondrat@xxxxxxxxxxxxxxxx> wrote: > > By the way, Atheros driver carl9170 uses MODULE_VERSION, > > should we consider killing it? > > Well its tied pretty heavily to the firmware which BTW is open and > GPLv2. Your driver does not need firmware (yet). Why exactly carl9170 > would use MODULE_VERSION though... or need it.. is perhaps Christian > can clarify on. Christian any reason to have MODULE_VERSION(), > anything that provide to userspace that cannot be obtained by the > kernel release it came from instead? Well, to make the api level of the firmware interface which is used by the driver accessible through modinfo without having to load the module. So a script check whenever the api matches by testing modinfo of the driver and fwinfo of the fw. However, this information is also printed out when the firmware is loaded/parsed. [ 150.588563] usb 1-10: driver API: 1.9.6 2012-07-07 [1-1] [ 150.594360] usb 1-10: firmware API: 1.9.6 2012-07-07 So, it's only really useful if you need to know in advance or in absence of a device. [So, it's not very useful in most cases] If you want to make a patch to remove it: here is my Acked-by: Christian Lamparter <chunkeey@xxxxxxxxxxxxxx> [Also, if you remove it, you can kill the ugly #defines which are used by it too] Regards, Chr -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
