On Wed, Oct 31, 2012 at 5:57 AM, Vladimir Kondratiev
<qca_vkondrat@xxxxxxxxxxxxxxxx> wrote:
>> You didn't also address my comments regarding WIL6210_ISR_COR #ifdef code.
>
> I added string with short explanation in Kconfig.
> Longer explanation: while clear-on-read is good for production mode, it makes
> debugging much harder - reading ISR registers clears interrupt, and one can no
> more monitor ISR with debugfs. So, when debugging ISR flows - and they still
> need some debugging - one have to use W1C mode. That's why it is still
> present.
>
> There are exactly 2 #ifdefs: one in ISR acknowledge routine, and other one in
> ISR configuration routine.
>
> Converting this #ifdef to run-time switch (say, module parameter) is possible,
> but I am not sure it would be better - changing ISR mode will cause reset; ans
> code will not more readable.
I meant, can you auto detect the preference for this option instead of
requiring a Kconfig entry? Ie, can you infer what the desired path
should be by poking at the driver? If not can you consider folding the
#ifdef juju code into a helper such as
#ifdef CONFIG_FOO
static void bar()
{
apples()
}
#else
static void bar()
{
oranges()
}
#endif
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
