Search Linux Wireless

Re: [RFC] mac80211: send deauth only with channel context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2012-10-29 at 11:48 +0200, Eliad Peller wrote:
> On Mon, Oct 29, 2012 at 11:12 AM, Johannes Berg
> <johannes@xxxxxxxxxxxxxxxx> wrote:
> > From: Johannes Berg <johannes.berg@xxxxxxxxx>
> >
> > When userspace asks to deauthenticate and we're just
> > authenticated (or still authenticating) send a deauth
> > frame instead of deleting the auth request.
> >
> why send a deauth if we are not authenticated yet?

Well we could have sent an auth frame already, for example. In fact we
most likely will have, unless we got stuck in probing the AP state.

> >         mutex_lock(&sdata->local->mtx);
> >         ieee80211_recalc_idle(sdata->local);
> >         mutex_unlock(&sdata->local->mtx);
> >
> > + out:
> > +       if (sent_frame)
> > +               __cfg80211_send_deauth(sdata->dev, frame_buf,
> > +                                      IEEE80211_DEAUTH_FRAME_LEN);
> > +
> 
> shouldn't the "out" label be before recalcing the idle state?

Yeah I suppose it should.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux