Search Linux Wireless

Re: [PATCHv3 2/2] mac80211: implement set_mcast_rate() callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 29, 2012 at 10:15:10AM +0100, Johannes Berg wrote:
> On Fri, 2012-10-26 at 17:57 +0200, Antonio Quartulli wrote:
> > The callback can be used with vif configured as
> > ADHOC or MESH_POINT only.
> 
> You said the same in the cfg80211 patch, so
> 
> > +int ieee80211_mcast_rate(struct ieee80211_sub_if_data *sdata,
> > +			 int rate[IEEE80211_NUM_BANDS])
> > +{
> > +	if (sdata->vif.type != NL80211_IFTYPE_ADHOC &&
> > +	    sdata->vif.type != NL80211_IFTYPE_MESH_POINT)
> > +		return -EOPNOTSUPP;
> 
> should that check be in cfg80211?

Ok, will change that.

> 
> OTOH, it seems it might be valid in AP mode as well?

as we discussed on IRC, the AP has no real mcast_rate parameter since it seems
to be chosen from the basic rates every time. How ever this would be an
interesting feature. Maybe we can add this later after this API change.

Cheers,


-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

Attachment: pgpUWmMWE2ad0.pgp
Description: PGP signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux