On Thu, Oct 25, 2012 at 12:43 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 2012-10-25 at 11:10 -0700, Javier Cardona wrote: >> Per IEEE Std. 802.11-2012, Sec 8.2.4.4.1, the sequence Control field is >> not present in control frames. We noticed this problem when processing >> Block Ack Requests. >> >> Signed-off-by: Javier Cardona <javier@xxxxxxxxxxx> >> Signed-off-by: Javier Lopez <jlopex@xxxxxxxxxxx> >> --- >> net/mac80211/rx.c | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c >> index f975f64..bf54336 100644 >> --- a/net/mac80211/rx.c >> +++ b/net/mac80211/rx.c >> @@ -1467,6 +1467,10 @@ ieee80211_rx_h_defragment(struct ieee80211_rx_data *rx) >> >> hdr = (struct ieee80211_hdr *)rx->skb->data; >> fc = hdr->frame_control; >> + >> + if (ieee80211_is_ctl(fc)) > > Different question -- why check _is_ctl rather than !_is_data? Per the Std, management frames can also be fragmented (not that I've ever seen one). The standard only excludes control frames. Javier -- Javier Cardona cozybit Inc. http://www.cozybit.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
