On Mon, Oct 22, 2012 at 3:29 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: >> what about other direct notification of BSS_CHANGED_BEACON_ENABLED >> (like in offchannel and ieee80211_do_stop)? should we call >> start_ap/stop_ap there as well? > > The one in do_stop() should probably just be cleaned up, cfg80211 will > now stop the AP operation while the interface goes down ... so that > won't actually do anything, but could be a concern for the old API > because it might cause an off/off transition. > cool. > For offchannel, I'm not sure. Does it really make sense to call it > there? I can do it, I suppose, but ... hmm. The software-offchannel > hopefully won't actually be needed much longer given channel > contexts ;-) :) i guess skipping these calls on software-offchannel transitions is reasonable, but it's worth documenting it (as it's different from BSS_CHANGED_BEACON_ENABLED notifications). Eliad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
