Search Linux Wireless

Re: [PATCH v6 4/6] wireless: use OR operation to set wiphy features

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bing Zhao <bzhao@xxxxxxxxxxx> writes:

> From: Johannes Berg <johannes.berg@xxxxxxxxx>
>
> The next patch will introduce a flag that is set
> by default in cfg80211 so drivers and mac80211
> need to use |= to set features they have so that
> they don't clear the already-set feature.
>
> We could set the flag in wiphy_register() instead
> of wiphy_new() to avoid this patch, but then the
> drivers couldn't *unset* flags they don't want to
> use even though the implementation is generic.
>
> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx>

Is there a way to check that drivers don't accidentally clear the flags
(ie. use '=' instead '|=')? For example by adding a dummy flag and
checking afterwards that it's not cleared?

I'm just worried that this detail might be too easy to miss, for example
somehow I had missed this patch and noticed only when rebasing ath6kl
patches.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux