On Mon, Oct 22, 2012 at 6:32 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Sat, 2012-10-20 at 19:03 -0700, Thomas Pedersen wrote: >> Before, a mesh STA would execute some code on behalf of AP or IBSS >> beacons. Since the mesh stack currently does not consider anything but >> other mesh STAs interesting, limit processing to just these and save a >> little overhead. > > I can apply this, but I think while you're at it the function deserves a > bit more thought: > >> Signed-off-by: Thomas Pedersen <thomas@xxxxxxxxxxx> > >> - if (elems.mesh_id && elems.mesh_config && >> - mesh_matches_local(sdata, &elems)) >> + if (mesh_matches_local(sdata, &elems)) >> mesh_neighbour_update(sdata, mgmt->sa, &elems); >> >> if (ifmsh->sync_ops) > > Why would you want to invoke sync_ops when the mesh is somebody else's > mesh, i.e. doesn't match local? Right now we only allocate a sta_info if mesh_matches_local, so sync_ops should simply fail its sta_info lookup and return. In the future we might want to allocate station entries for non-peers as well since it is useful to track the Toffset of non-peer neighbors for beacon collision avoidance and scheduling MCCAOP interference periods. This is also required by the standard FWIW. Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
