Search Linux Wireless

RE: [PATCH] iw: add lowpri and flush scan operands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Johannes,

> > --- a/nl80211.h
> > +++ b/nl80211.h
> 
> No need to send nl80211.h updates, I do those directly by copying the
> new file to avoid mismatch issues.

OK, will remove nl80211 change.

> 
> 
> > -TOPLEVEL(scan, "[-u] [freq <freq>*] [ies <hex as 00:11:..>] [ssid <ssid>*|passive]", 0, 0,
> > +TOPLEVEL(scan, "[-u] [freq <freq>*] [ies <hex as 00:11:..>] [ssid <ssid>*|passive|lowpri|flush]",
> 0, 0,
> 
> This seems a little wrong, you can't give lowpri/flush after giving
> SSIDs, so it should probably be written as

I think we are adding lowpri/flush support as similar to 'passive' flag.

> 
> ... [ies <...>] [lowpri|flush] [ssid ...]
> 
> The SSID list has to be last since no keyword can terminate it
> (everything could be a valid SSID)

Let me know if you still want to implement lowpri/flush this way.

> 
> >  	NL80211_CMD_TRIGGER_SCAN, 0, CIB_NETDEV, handle_scan,
> >  	 "Trigger a scan on the given frequencies with probing for the given\n"
> > +
> 
> spurious newline?

It will be removed in v2.

Thanks,
Bing
��.n��������+%������w��{.n�����{���zW����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux