Search Linux Wireless

Re: [PATCH NEXT 2/2] rtlwifi: rtl8192c: rtl8192ce: rtl8192cu: rtl8192se: rtl8192de: Shorten some variable names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2012-10-12 at 10:52 -0500, Larry Finger wrote:
> The private data areas for these drivers contain some very long variable
> names that cause difficulty in fitting source lines to an 80-character
> limit.

[]

> diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
[]
> @@ -177,8 +177,8 @@ static void rtl92c_dm_diginit(struct ieee80211_hw *hw)
>  	dm_digtable->rx_gain_range_max = DM_DIG_MAX;
>  	dm_digtable->rx_gain_range_min = DM_DIG_MIN;
>  	dm_digtable->backoff_val = DM_DIG_BACKOFF_DEFAULT;
> -	dm_digtable->backoff_val_range_max = DM_DIG_BACKOFF_MAX;
> -	dm_digtable->backoff_val_range_min = DM_DIG_BACKOFF_MIN;
> +	dm_digtable->back_range_max = DM_DIG_BACKOFF_MAX;
> +	dm_digtable->back_range_min = DM_DIG_BACKOFF_MIN;

Hi Larry, good idea but it looks like maybe you grepped
for long variable names with something like "\w{20,}".

Please try to convert all the similarly grouped names at
the same time.

iow: backoff_val should probably be changed too.

I didn't read any further.  cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux