On 10/12/2012 01:28 PM, Arend van Spriel wrote: > The include file linux/ieee80211.h contains three definitions for > the same thing in enum ieee80211_eid due to historic changes: > > /* Information Element IDs */ > enum ieee80211_eid { > : > WLAN_EID_WPA = 221, > WLAN_EID_GENERIC = 221, > WLAN_EID_VENDOR_SPECIFIC = 221, > : > }; > > The standard refers to this as "vendor specific" element so the > other two definitions are better not used. This patch changes the > wireless drivers to use one definition, ie. WLAN_EID_VENDOR_SPECIFIC. Why not remove _WPA and _GENERIC from ieee80211.h at the same time so that nobody else won't use them in the future? > Cc: Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> > Cc: Jouni Malinen <j@xxxxx> > Cc: Stanislav Yakovlev <stas.yakovlev@xxxxxxxxx> > Cc: Dan Williams <dcbw@xxxxxxxxxx> > Cc: Bing Zhao <bzhao@xxxxxxxxxxx> > Cc: Larry Finger <Larry.Finger@xxxxxxxxxxxx> > Signed-off-by: Arend van Spriel <arend@xxxxxxxxxxxx> For the ath6kl part: Acked-by: Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html