Also stick to coding style. use "strcmp ( , ) == 0" instead of (!strcmp( , )) Signed-off-by: Ashok Nagarajan <ashok@xxxxxxxxxxx> --- mesh.c | 10 +++------- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/mesh.c b/mesh.c index 3077abf..4fdad6a 100644 --- a/mesh.c +++ b/mesh.c @@ -232,19 +232,15 @@ static void print_all_mesh_param_descr(void) static const struct mesh_param_descr *find_mesh_param(const char *name) { int i; - const struct mesh_param_descr *mdescr = NULL; /* Find out what mesh parameter we want to change. */ for (i = 0; i < ARRAY_SIZE(_mesh_param_descrs); i++) { - if (!strcmp(_mesh_param_descrs[i].name, name)) + if (strcmp(_mesh_param_descrs[i].name, name) == 0) return _mesh_param_descrs + i; } - if (!mdescr) { - print_all_mesh_param_descr(); - return NULL; - } - return mdescr; + print_all_mesh_param_descr(); + return NULL; } /* Setter */ -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html