On Thu, Oct 04, 2012 at 07:43:15PM +0200, Sven Eckelmann wrote: > All defines for REG_WRITE in Atheros wireless drivers use the order "ah", > "register" and "value". hw.c is the only file using the order "ah", "value" and > "register". > > drivers/net/wireless/ath/ath9k/hw.h:#define REG_WRITE(_ah, _reg, _val) \ > drivers/net/wireless/ath/key.c:#define REG_WRITE(_ah, _reg, _val) (common->ops->write)(_ah, _val, _reg) > > This inconsistent definition can easily lead to implementation errors. The > modification doesn't change the behavior of the driver or the generated code. > > Signed-off-by: Sven Eckelmann <sven@xxxxxxxxxxxxx> > Signed-off-by: Simon Wunderlich <siwu@xxxxxxxxxxxxxxxxxx> Acked-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxxxxxxxx> Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html