On Wed, Oct 3, 2012 at 3:54 PM, Goldenshtein, Victor <victorg@xxxxxx> wrote:
> On Mon, Sep 10, 2012 at 2:25 PM, Johannes Berg
> <johannes@xxxxxxxxxxxxxxxx> wrote:
>>
>>> +static int
>>> +ieee80211_ap_process_chanswitch(struct wiphy *wiphy,
>>> + struct net_device *dev,
>>> + struct ieee80211_ap_ch_switch *ap_ch_switch)
>>> +{
>>> + struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
>>> + struct ieee80211_local *local = sdata->local;
>>> +
>>> + if (!local->ops->channel_switch)
>>> + return -EOPNOTSUPP;
>>> +
>>> + if (!ap_ch_switch || !ap_ch_switch->channel)
>>> + return -EINVAL;
>>> +
>>> + drv_ap_channel_switch(local, ap_ch_switch);
>>> + return 0;
>>
>> errors are not possible?
>>
>
> driver is not allowed to fail here.
>
on second thought ;) can't see why we can't propagate driver's return
value to userspace, which will deal with the error code.
--
Thanks,
Victor.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
