Search Linux Wireless

Re: 802.11w bip_aad() bug ?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2012-10-01 at 15:13 +0000, Chaoxing Lin wrote:
> Gentlemen,
> 
> In kernel/net/mac80211/wpa.c function bip_add is as below (in the end).
> 
> I think the aad[1] should be 
> aad[1] = skb->data[1] & ~(BIT(3) | BIT(4) | BIT(5));
> 
> 
> Reference 1: ieee802.11-2012 page 1212
> "FC-MPDU Frame Control field, with:
> 1) Retry bit (bit 11) masked to 0
> 2) Power Management bit (bit 12) masked to 0
> 3) More Data bit (bit 13) masked to 0"
> 
> Reference 2: ieee80211-2012, page 404, Figure 8-12
> 
> The bit 11 should be bit 3 of second byte.
> The bit 12 should be bit 4 of second byte.
> The bit 13 should be bit 5 of second byte.
> 
> 
> What did I miss??

Nothing, we just fixed that:
http://git.kernel.org/?p=linux/kernel/git/jberg/mac80211.git;a=commitdiff;h=33766368f6532313571534f9112b1796d6651bbe

(note that the URL might not be accessible yet, I pieced it together and
had evidently forgotten to push out this change before, so you may have
to wait for git.kernel.org to sync with the master)

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux