Search Linux Wireless

Re: [PATCH] mac80211: use __printf attribute in debugfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2012-09-30 at 08:52 -0700, Joe Perches wrote:
> On Sun, 2012-09-30 at 17:16 +0200, Johannes Berg wrote:
> > The internal function mac80211_format_buffer() has a
> > printf-style argument list, so add the attribute to
> > have gcc verify that list.
> []
> > diff --git a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c
> []
> > @@ -17,8 +17,8 @@
> []
> > -int mac80211_format_buffer(char __user *userbuf, size_t count,
> > -				  loff_t *ppos, char *fmt, ...)
> > +int __printf(4, 5) mac80211_format_buffer(char __user *userbuf, size_t count,
> > +					  loff_t *ppos, char *fmt, ...)
> >  {
> >  	va_list args;
> >  	char buf[DEBUGFS_FORMAT_BUFFER_SIZE];
> 
> Good idea, but this needs to be added to the prototype
> in debugfs.h not on the function itself.

Oops, good catch, will fix that.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux