On Thu, 2012-09-27 at 17:28 -0500, Larry Finger wrote: > On 09/26/2012 11:45 AM, Joe Perches wrote: > > rate_mask uses: > > > > u32 ratr_bitmap = (u32) mac->basic_rates; > > ... > > u8 rate_mask[5]; > > ... > > [sets ratr_bitmap as u32] > > ... > > *(u32 *)&rate_mask = ((ratr_bitmap & 0x0fffffff) | > > ratr_index << 28); > > ... > > rtl92c_fill_h2c_cmd(hw, H2C_RA_MASK, 5, rate_mask); > > > > Looks like a possible endian misuse to me. > > After a second look at the code, I don't think this is an endian issue; however, > I am proposing the following changes to remove any doubt: I believe if it wasn't an endian problem, then the new code makes it one. > Index: wireless-testing-new/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c > =================================================================== > --- wireless-testing-new.orig/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c > +++ wireless-testing-new/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c > @@ -1964,8 +1965,9 @@ static void rtl92ce_update_hal_rate_mask > > RT_TRACE(rtlpriv, COMP_RATR, DBG_DMESG, > "ratr_bitmap :%x\n", ratr_bitmap); > - *(u32 *)&rate_mask = (ratr_bitmap & 0x0fffffff) | > - (ratr_index << 28); > + for (i = 0; i < 3; i++) > + rate_mask[i] = ratr_bitmap & (0xff << (i * 4)); rate_mask is u8, doesn't this needs (calc) >> (i * 8) > + rate_mask[3] = (ratr_bitmap & 0x0f000000) | (ratr_index << 28); Perhaps you meant: ((ratr_bitmap & 0x0f000000) >> 24) | (ratr_index << 4) > rate_mask[4] = macid | (shortgi ? 0x20 : 0x00) | 0x80; > RT_TRACE(rtlpriv, COMP_RATR, DBG_DMESG, > "Rate_index:%x, ratr_val:%x, %*phC\n", > > The downstream routine uses this info as an array of u8, thus it is OK. A proper > patch will be sent later. At least we avoid that ugly cast. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
