On Fri, 2012-09-21 at 08:45 +0000, Mahesh Palivela wrote:
> +/**
> + * struct ieee80211_vht_operation - VHT operation IE
kernel-doc should have member descriptions
> +void ieee80211_vht_cap_ie_to_sta_vht_cap(struct ieee80211_sub_if_data *sdata,
> + struct ieee80211_supported_band *sband,
> + struct ieee80211_vht_cap *vht_cap_ie,
> + struct ieee80211_sta_vht_cap *vht_cap)
> +{
> + BUG_ON(!vht_cap);
Please don't use BUG_ON(), maybe "if (WARN_ON_ONCE(...)) return;"?
> + /*
> + * The bits listed in this expression should be
> + * the same for the peer and us, if the station
> + * advertises more then we can't use those thus
> + * we mask them out.
> + */
> + vht_cap->cap = le16_to_cpu(vht_cap_ie->vht_cap_info) &
> + sband->vht_cap.cap;
There are no bits listed in this expression? :)
Also, I'm sure that not all bits are symmetric, e.g. beamformer and
beamformee are asymmetric.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
