OK, but which netif_receive_skb(), as I count 5 occurrences in net/mac80211/rx.c ? Instead of skb_linearize() calls you could try several values of XXX in pskb_may_pull(skb, XXX) So that you make sure XXX bytes are available in skb->head, and not the whole frame. One you know the limit for XXX, it might give a clue where a pskb_may_pull(skb, XXX) is missing. On Thu, Sep 20, 2012 at 2:35 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > Hi, > >> > 56138f5 iwlwifi: dont pull too much payload in skb head >> > 3edaf3e mac80211: manage AP netdev carrier state >> >> The second patch (AP carrier state) actually exposed a connman issue >> which I fixed and submitted a connman patch: >> http://lists.connman.net/pipermail/connman/2012-September/011232.html >> >> However, Eric's patch still causes tethering problems to me. > > > Let me recap a bit. Artem is using connman, which sets up the wifi > interface as part of a bridge. It runs wpa_supplicant to create an AP > (only AP and mesh mode interfaces can be bridged anyway). > > > Eric, you said: > >> I would say some part of the stack assumes a header (I dont know wich >> one ?) is pulled in skb->head/data, and thats a bug. >> >> Always use pskb_may_pull(skb, XXX) to make sure you can access XXX >> bytes in skb->data > > I thought we'd figure out which part of the stack assumes a header, so I > asked Artem to test a one-line patch which adds "skb_linearize()" before > "netif_receive_skb()" in mac80211. This makes it work, but I'm not sure > where after that the bad assumption might be. > > johannes > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
