On 09/18/2012 12:37 PM, Johannes Berg wrote:
On Tue, 2012-09-18 at 10:59 +0200, Arend van Spriel wrote:
The kerneldoc comment for .sched_scan_stop() callback describes a
driver_initiated flag, but the interface does not hold such a flag.
Reviewed-by: Franky (Zhenhui) Lin <frankyl@xxxxxxxxxxxx>
Reviewed-by: Hante Meuleman <meuleman@xxxxxxxxxxxx>
Signed-off-by: Arend van Spriel <arend@xxxxxxxxxxxx>
---
Hi Johannes,
Was working on scheduled scan support for brcmfmac and got a little
confused about .sched_scan_stop() documentation. Not sure if this
was stale documentation.
Yes I believe this was some sort of circular call that we removed
(driver calls stop, cfg80211 tells driver it itself stopped??)
I can come up with a scenario, where scheduled scan related cleanup is
done in sched_scan_stop and needs different behaviour when initiated by
driver as opposed to user-space initiated. However, it feels awkward so
good riddance.
I'll apply this (and fix the typo ("obsolete") in the subject)
johannes
Thanks (and thanks for fixing the subject ;-) ).
Gr. AvS
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
