Search Linux Wireless

Re: [PATCH 2/2] mac80211: reply to AUTH frame with a DEAUTH if sta allocation fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 05, 2012 at 03:58:23 +0200, Johannes Berg wrote:
> On Sun, 2012-08-26 at 17:34 +0200, Antonio Quartulli wrote:
> > Whenever a host gets an AUTH frame it first allocates a new station and then
> > replies with another AUTH frame. However, if sta allocations fails the host
> > should send a DEAUTH frame instead to tell the other end that something went
> > wrong
> 
> Well, ok, but...
> 
> >  	/*
> > +	 * if we have any problem in allocating the new station, we reply with a
> > +	 * DEAUTH frame to tell the other end that we had a problem
> > +	 */
> > +	if (!sta) {
> > +		ieee80211_send_deauth_disassoc(sdata, sdata->u.ibss.bssid,
> > +					       IEEE80211_STYPE_DEAUTH,
> > +					       WLAN_REASON_UNSPECIFIED, true,
> > +					       deauth_frame_buf);
> 
> You can't call the function in IBSS mode, it accesses sdata->u.mgd. You
> should probably fix that in the first patch and make it conditional on
> the sdata->vif.type actually being station mode.

argh ok. I see the problem. Will fix and send v2.

Thank you


-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

Attachment: pgphzoD4hN_TY.pgp
Description: PGP signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux