Hello Johannes Berg,
This is a semi-automatic email about new static checker warnings.
The patch f142c6b906da: "mac80211: support P2P Device abstraction"
from Jun 18, 2012, leads to the following Smatch complaint:
net/mac80211/iface.c:1168 ieee80211_setup_sdata()
error: we previously assumed 'sdata->dev' could be null (see line 1134)
net/mac80211/iface.c
1133 /* only monitor/p2p-device differ */
1134 if (sdata->dev) {
^^^^^^^^^^
New test.
1135 sdata->dev->netdev_ops = &ieee80211_dataif_ops;
1136 sdata->dev->type = ARPHRD_ETHER;
1137 }
[snip]
1167 case NL80211_IFTYPE_MONITOR:
1168 sdata->dev->type = ARPHRD_IEEE80211_RADIOTAP;
^^^^^^^^^^^^
Old dereference.
1169 sdata->dev->netdev_ops = &ieee80211_monitorif_ops;
1170 sdata->u.mntr_flags = MONITOR_FLAG_CONTROL |
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
