Search Linux Wireless

Re: [PATCH v2 6/6] rt2x00: rt2800 - Make probe_hw function common between PCI and USB.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index c3cae1d..2ad3b7a 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -44,6 +44,13 @@
>  #include "rt2800.h"
>
>  /*
> + * Allow hardware encryption to be disabled.
> + */
> +static bool modparam_nohwcrypt = false;
> +module_param_named(nohwcrypt, modparam_nohwcrypt, bool, S_IRUGO);
> +MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");

I am not particularly fond of this change, I would like to have the
module parameters inside the actual drivers instead of inside one of
the
library modules. I don't know if there is a policy for modules which
says something about these situations, but my preference would be
that the module parameters are inside rt2800pci and rt2800usb, and
that the value would be passed to rt2800lib.

If there is isn't a simple and clean way to do that, then we can take
this patch though...

Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux