Search Linux Wireless

Re: Scalable approach for nl80211_feature_flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Vladimir Kondratiev <qca_vkondrat@xxxxxxxxxxxxxxxx> writes:

> There is 'new' approach for specifying various wifi driver flags,
> using enum nl80211_feature_flags and wiphy.features.
>
> Problem is, wiphy.features is u32, i.e. it is not scalable
> beyond 32 flags.

And currently we have used 4 out of 32. During the 10 months it has
existed we have added four new flags, which makes it a rate of 2,5
months per flag. Based on this it takes over five years to fill
that u32. So I'm not really worried about that right now.

> I propose to re-define 'features' approach - convert it to
> use 'bitmap' API like DECLARE_BITMAP for the 'features' and
> use bit numbers rather then raw values in the
> enum nl80211_feature_flags. Last value will be defined like
> NL80211_FEATURE_MAX, and 'features' will auto-size using
> DECLARE_BITMAP(features, NL80211_FEATURE_MAX);
>
> Then, user space tools need to be modified as well.

Please take into account that the kernel needs to be backwards
compatible and you cannot just change an existing nl80211 attribute to
something else. IMHO this isn't worth the trouble, we manage with the
u32 just fine for now.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux