On Wed, 2012-08-15 at 17:15 -0700, Thomas Pedersen wrote:
> Don't accept WoW patterns longer than supported by firmware.
>
> Reported-by: Haijun Jin <nhjin@xxxxxxxxxxxxxxxx>
> Signed-off-by: Thomas Pedersen <c_tpeder@xxxxxxxxxxxxxxxx>
> ---
> drivers/net/wireless/ath/ath6kl/cfg80211.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> index bd003fe..ffa18f3 100644
> --- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
> +++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
> @@ -1876,6 +1876,9 @@ static int ath6kl_wow_usr(struct ath6kl *ar, struct ath6kl_vif *vif,
> /* Configure the patterns that we received from the user. */
> for (i = 0; i < wow->n_patterns; i++) {
>
> + if (wow->patterns[i].pattern_len > WOW_MASK_SIZE)
> + return -EINVAL;
> +
No objection, but doesn't nl80211 already validate that (assuming you
give the right pattern_max_len, of course)?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
