Hello Ying Luo,
The patch b877f4cf5af8: "mwifiex: add AES_CMAC support in
key_material cmd" from Aug 3, 2012, leads to the following warning:
drivers/net/wireless/mwifiex/sta_cmd.c:692
mwifiex_cmd_802_11_key_material()
error: memcpy() 'param->key' too small (16 vs 32)
656 } else if (enc_key->key_len == WLAN_KEY_LEN_TKIP) {
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
We assume a 32 byte key_len here.
657 dev_dbg(priv->adapter->dev, "cmd: WPA_TKIP\n");
658 key_material->key_param_set.key_type_id =
659 cpu_to_le16(KEY_TYPE_ID_TKIP);
660 key_material->key_param_set.key_info =
661 cpu_to_le16(KEY_ENABLED);
[snip]
686 if (le16_to_cpu(key_material->key_param_set.key_type_id) ==
687 KEY_TYPE_ID_AES_CMAC) {
688 struct mwifiex_cmac_param *param =
689 (void *)key_material->key_param_set.key;
690
691 memcpy(param->ipn, enc_key->pn, IGTK_PN_LEN);
692 memcpy(param->key, enc_key->key_material,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
693 enc_key->key_len);
^^^^^^^^^^^^^^^^
"param->key" only has space for 16 bytes.
694
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
