Search Linux Wireless

Re: [PATCH] cfg80211: Fix for crash in cfg80211

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/7/2012 5:12 PM, Johannes Berg wrote:
On Tue, 2012-08-07 at 12:40 +0530, Srinivasan B wrote:
Patch Description:
                      cfg80211 module crashes when cfg80211 & mac80211
loaded and unloading lmac driver.

Scenario Explanation:
                      (Step 1) : cfg80211, mac80211 and lmac driver
modules are loaded initially.
                      (Step 2) : unload the lmac driver.
                                      then any dev calls to stack causes
the crash.
Code Changes:
                      dev->ethtools_ops is assigned during
NETDEV_REGISTER and the same can be cleared during NETDEV_UNREGISTER.

This doesn't make any sense to me at all.

cleanup of ethtools_ops pointer is required upon netdev_unreg notification. we are assigning this pointer to cfg80211_ethtool_ops on netdev_reg notification. Is it not required?

we have seen crash when keeping cfg80211 and mac80211 loaded and lmac driver unloaded. With this fix, we didn't see crash. Crash doesn't happen right away. Only when some operation trying to access ethtool_ops.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux