Thanks for looking at this! 2012/8/5 Florian Fainelli <florian@xxxxxxxxxxx>: > Le dimanche 05 août 2012 22:03:07, Rafał Miłecki a écrit : >> This is basic driver for NAND flash memory that allows reading it's >> content. It was succesfully tested on Netgear WNDR4500 which is BCM4706 >> based router. >> >> This driver has been written using specs at: >> http://bcm-v4.sipsolutions.net/NAND_Flash > > The big problem that I see with your driver is that it does not interface with > the MTD subsystem, and therefore: > > - does not conform to the MTD API for reading pages, blocks etc... My idea for bcma responsibilities consists of: 1) Detecting hardware 2) Providing basic access to it This is what (I believe) I provided with that submitted patch. I'm not registering MTD driver directly in bcma, just like we don't register ieee80211 device for 80211 core or netdev for ETH core. After providing basic/low-level access in bcma my plan is to write real MTD driver. In this driver I could make use of functions from bcma_chipcommon_nflash.[ch]. Does it sound better now? > - duplicates NAND flash detection in a manner which is far less robust than > what the MTD NAND subsystem already does Hm, do you mean there is some MTD driver detecting NAND flash on BCMA? I wasn't aware of that. Grepping drivers/mtd for "bcma" didn't give me anything. Can you say something more about this? > I guess that this driver enables you do some stuff on your router, but clearly > you should aim at writing a real MTD driver instead of having such an ad-hoc > solution. That "do some stuff" means almost nothing right now. My plan (as explained earlier) is to write MTD driver. -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
