On Thu, 2012-08-02 at 11:25 -0600, Daniel Drake wrote: > On Thu, Aug 2, 2012 at 10:26 AM, Johannes Berg > <johannes@xxxxxxxxxxxxxxxx> wrote: > > Hmm. Then again, I think we can call cfg80211_process_wdev_events() from > > case NETDEV_UNREGISTER though, probably after removing from the list. > > Maybe you could try that? > > That solves the issue - confirmed that kmemleak now shuts up, and with > some added printks to confirm event creation and freeing. > Patch coming up, titled: cfg80211: process pending events when > unregistering net device Nice, thanks! > Even if libertas isn't quite doing the right thing here, I think this > is the right thing to do. I guess there are other situations, perhaps > more legitimate, where we can reach this point with events in the > queue. Yes, I agree. I just wasn't completely sure this would be OK when I looked first, and then started wondering why it didn't happen with mac80211, but that doesn't send the event. > > I'm not 100% sure about the API in this area right now though, it's been > > a while and I never worked much with this API (rather than the mac80211 > > one with auth/assoc/disassoc/deauth.) > > I think we both feel that removing it is correct. I'll test this when > I find some free time, and if things seem OK i'll post a libertas > patch in addition to the cfg80211 fix. It shouldn't hurt either way, since if the event is there but we're already disconnected we'll just ignore it, afaict. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
