On Fri, Jul 27, 2012 at 7:30 AM, Christian Lamparter <chunkeey@xxxxxxxxxxxxxx> wrote: > On Friday 27 July 2012 05:52:49 Javier Cardona wrote: >> On Thu, Jul 26, 2012 at 1:12 PM, Christian Lamparter >> <chunkeey@xxxxxxxxxxxxxx> wrote: >> > On Thursday 26 July 2012 21:59:03 Javier Lopez wrote: >> >> This patch contains following modifications: >> >> >> >> - Add mesh capabilities on fw.c to permit creation of mesh >> >> interfaces using this driver. >> >> >> >> - Modify carl9170_set_operating_mode, to use AP-style beaconing >> >> with mesh interfaces. >> >> >> >> - Allow beacon updates for NL80211_IFTYPE_MESH_POINT type in >> >> carl9170_handle_command_response. >> >> >> >> Signed-off-by: Javier Lopez <jlopex@xxxxxxxxxxx> >> > Hm, what about virtual interfaces? >> > >> > Do you think it's save to share a MESH node with >> > a STA, IBSS, AP interface on the same hardware? >> >> Does this hardware support multiple beacons? >> If not, we probably should limit the driver >> to only accept one beaconing vif at a time >> (e.g. one mesh vif + multiple STAs vifs ok). > oh yes. In fact, Due to your modifycations to fw.c > you have to update carl9170_op_add_interface as well. > As you are currently claiming any mesh/ap/sta > combination, even though it's not supported in the > code atm. > > Just add a case for NL80211_IFTYPE_MESH in the > switch (main_vif->type) block and to the > if ((vif->type == ...) below. > >> > On a side node: Can you tell me anything about >> > the crypto of mesh traffic? Because currently, >> > the code will disable any hardware crypto >> > offload for any mode other than STA and AP. >> >> The hardware crypto needs to support one tx/rx >> pairwise key per peer, a groupwise key for each >> peer and management frame protection. >> Not sure if this is the case for this hardware, >> so until we do, it seems reasonable to disable >> crypto offload. > ok, a groupwise key for each peer is not possible > with the hw. (no need to change anything, swcrypto > is selected in this case). > > Regards, > Chr > > BTW: Did you do any experiments? I.e.: Does it really > work? Basic peering and pinging with ath9k_htc seems to work. We only have one of these cards, so we cannot run our full test suite. Testing will continue when we receive more cards. Javier -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
