Search Linux Wireless

Re: [PATCH] mac80211: add PS flag to bss_conf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-07-25 at 18:49 +0300, Eliad Peller wrote:

> @@ -2085,6 +2092,9 @@ static int ieee80211_set_power_mgmt(struct wiphy *wiphy, struct net_device *dev,
>  
>  	ieee80211_recalc_ps(local, -1);
>  
> +	sdata->vif.bss_conf.ps = ieee80211_powersave_allowed(sdata);
> +	ieee80211_bss_info_change_notify(sdata, BSS_CHANGED_PS);

It need not have changed, since the AP could be broken? We might also
not even be associated, so I don't think this is right.


I also wonder if ieee80211_recalc_ps() should use vif.bss_conf.ps
instead of calling powersave_allowed() itself?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux