Search Linux Wireless

Re: [ath5k-devel] [PATCH 2/2] ath5k: fix phy_init() to respect user txpower changes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Nick,

Nick Kossifidis schrieb:

> 2012/7/26 Thomas Huehn <thomas@xxxxxxxxxxxxxxxxxxxxxxx>:

> There is nothing in your patch that suggests that's related to this.
> Anyway there's a simple way to fix this:
> 
> Just move this:
> 
> 3575         /* Min/max in 0.25dB units */
> 3576         ah->ah_txpower.txp_min_pwr = 2 * rates[7];
> 3577         ah->ah_txpower.txp_cur_pwr = 2 * rates[0];
> 3578         ah->ah_txpower.txp_ofdm = rates[7];
> 
> above the for loop and you are done.
> 
> Note rates[i] don't hold tx power values, they hold indices to the
> channel powertable.
> 


Are you agreeing that current ath5k txpower handling set from user space
is not working and we need to fix it ?
Beside that, what about a channel switch and wrongly re-use txp_cur_pwr
on a channel witch other max power levels ?

Lets wait on Felix opinion what he has in mind.

Greetings Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux