Hi Chun-Yeow, On Tue, Jul 24, 2012 at 1:40 PM, Yeoh Chun-Yeow <yeohchunyeow@xxxxxxxxx> wrote: > Hi, Thomas > >>> sta->last_rx = jiffies; >> >> You should avoid duplicating this assignment. > > I think that we should also update the sta->last_rx if the > sta->plink_state is not NL80211_PLINK_ESTAB, am I right? The point Thomas is making is that this assignment happens both when the if statement's condition is true and when it's false. So you could remove it from the if statement and move the one that's after the if statement above the if statement and the code would be functionally equivalent and cleaner. Thanks, -- Julian Calaby Email: julian.calaby@xxxxxxxxx Profile: http://www.google.com/profiles/julian.calaby/ .Plan: http://sites.google.com/site/juliancalaby/ -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
