Search Linux Wireless

Re: [PATCH] mac80211: VHT (11ac) Association

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2012-07-23 at 09:13 +0000, Mahesh Palivela wrote:

> @@ -359,6 +359,7 @@ enum ieee80211_sta_flags {
>  	IEEE80211_STA_NULLFUNC_ACKED	= BIT(8),
>  	IEEE80211_STA_RESET_SIGNAL_AVE	= BIT(9),
>  	IEEE80211_STA_DISABLE_40MHZ	= BIT(10),
> +	IEEE80211_STA_DISABLE_11AC	= BIT(11),

I'd prefer this being named DISABLE_VHT, even though we never renamed
the old DISABLE_11N (yet)


> +	BUILD_BUG_ON(sizeof(vht_cap) != sizeof(sband->vht_cap));
> +
> +	memcpy(&vht_cap, &sband->vht_cap, sizeof(vht_cap));
> +	//ieee80211_apply_vhtcap_overrides(sdata, &ht_cap);

Please just remove that line

>  static void ieee80211_send_assoc(struct ieee80211_sub_if_data *sdata)
>  {
>  	struct ieee80211_local *local = sdata->local;
> @@ -503,6 +524,10 @@ static void ieee80211_send_assoc(struct ieee80211_sub_if_data *sdata)
>  		ieee80211_add_ht_ie(sdata, skb, assoc_data->ap_ht_param,
>  				    sband, local->oper_channel, ifmgd->ap_smps);
>  
> +	if (!(ifmgd->flags & IEEE80211_STA_DISABLE_11AC))
> +		ieee80211_add_vht_ie(sdata, skb, sband);
> +
> +

Please remove the extra blank line. You also forgot to account for the
size of this field so the skb might be too short.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux