On Tue, 2012-07-17 at 21:42 -0700, Ashok Nagarajan wrote:
> Reviewed-by: Thomas Pedersen <thomas@xxxxxxxxxxx>
I'd have expected better from you, Thomas :-P
> * @mcast_rate: multicat rate for Mesh Node [6Mbps is the default for 802.11a]
> + * @basic_rates: bitmap of basic rates to use when creating the mesh
> *
> * These parameters are fixed when the mesh is created.
> */
> @@ -932,6 +933,7 @@ struct mesh_setup {
> bool is_authenticated;
> bool is_secure;
> int mcast_rate[IEEE80211_NUM_BANDS];
> + u32 basic_rates;
This doesn't make sense. Why give mcast rate for both bands, but basic
rates only for one band?
> + if (!setup->basic_rates) {
> + setup->basic_rates = ieee80211_mandatory_rates(
> + rdev->wiphy.bands[setup->channel->band],
> + setup->channel->band);
> +
> + }
No need for braces nor the extra blank line.
> + if (info->attrs[NL80211_ATTR_BSS_BASIC_RATES] &&
> + !WARN_ON(!wdev->preset_chan)) {
WARN_ON? Really? That doesn't seem right. Also, doesn't the mesh allow
joining with a channel given to the join function, so that preset_chan
will be NULL here?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
