On Tue, 2012-07-17 at 14:57 +0200, Thomas Huehn wrote: > > Ok first of all, please actually compile the tree after your changes. It > > doesn't. When it does, please fix > > I always do compile the compat-wireless-tree after changes I introduce, > and it compiles without errors in the case of this mac80211:sta-remove > patch. But as my build tree is based on the OpenWrt environment, it > might be not 100% in sync. Could you be a bit more explicit where does > it brake in you case (which function, driver...) ? No, I'm not going to play that game. Make sure it compiles on wireless-next. > I guess you refer to the comment in mac80211.h, struct tx_info that I > removed: > - * The TX control's sta pointer is only valid during the ->tx call, > - * it may be NULL. > > I am not sure what you want me to keep here as comment. As the sta > pointer is moved into the new struct tx_control and the remaining > pointers in the tx_info->control structure (vif, hw_key) are ALL only > valid during the ->tx call and may be NULL. So I could think of adding a > comment to tx_control about the sta been NULL, but anything more ? It's also not allowed to copy the pointer, due to RCU, which is information you lost. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
