On Thu, 2012-07-12 at 19:26 +0300, Eliad Peller wrote:
> >> why not always do it only on IFACE_UP?
> >
> > Yeah .. thought so too at first, but it doesn't work, say you have this
> > situation:
> >
> > * up moni0 (monitor)
> > * up wlan0 (managed)
> >
> > Then the set_monitor_enabled(false) should happen before wlan0 is
> > brought up, otherwise mac80211/the driver will correctly reject wlan0
> > being brought up.
> >
> but you don't call set_monitor_enabled(false) on pre_up in your
> patch...
It does, this is what happens when wlan0 is brought up:
> rdev->num_running_ifaces += num;
> if (iftype == NL80211_IFTYPE_MONITOR)
> rdev->num_running_monitor_ifaces += num;
will inc num_running_ifaces by one
> monitors_only = cfg80211_has_monitors_only(rdev);
will be false, while it was previously true
> if (monitors_only && rdev->monitor_only_enabled)
> return;
doesn't return, since monitors_only == false
> if (!monitors_only && !rdev->monitor_only_enabled)
> return;
doesn't return since monitor_only_enabled == true
> if (monitors_only) {
no, we'll go into else
> } else {
> rdev->monitor_channel = NULL;
> rdev->monitor_channel_type = NL80211_CHAN_NO_HT;
> if (rdev->ops->set_monitor_enabled)
> rdev->ops->set_monitor_enabled(&rdev->wiphy, false);
> }
and call set_monitor_enabled(false)
> so i guess the driver will still get its add_interface
> callback while the monitor is enabled?
add_interface is a long time ago. I'm talking about bringing it up, and
PRE_UP happens before the ndo_open() is called for the interface.
> afaict, the only effect of pre_up is updating
> rdev->num_running_ifaces/rdev->num_running_monitor_ifaces, which don't
> seem to matter much...
No :-)
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
