On Wed, 2012-07-11 at 12:20 -0700, Thomas Pedersen wrote:
> Let the user configure serveral TX error conection quality monitoring
> parameters: % error rate, survey interval, and # of attempted packets.
>
> On exceeding the TX failure rate over the given interval, the driver
> will send a CQM notify event with the actual TX failure rate and
> packets attempted.
It seems useful to me to also send the interval, in case somebody else
is listening to the events or in case the interval was changed, etc.?
> + * @NL80211_ATTR_CQM_TXE_RATE: TX error rate in %. Minimum % of TX failures
> + * during the given %NL80211_ATTR_CQM_TXE_INTVL before an
> + * %NL80211_CMD_NOTIFY_CQM with reported %NL80211_ATTR_CQM_TXE_RATE and
> + * %NL80211_ATTR_CQM_TXE_PKTS is generated.
Is percentage fine-grained enough? I guess it is?
> + * @NL80211_ATTR_CQM_TXE_PKTS: number of TX attempts in a given
> + * %NL80211_ATTR_CQM_TXE_INTVL before %NL80211_ATTR_CQM_TXE_RATE is
> + * checked.
I'm not sure I'd say "TX attempts", that gets confusing, do you count
retries? I guess not. Maybe say "attempted packets" or something else
that includes TX too?
> + * @NL80211_ATTR_CQM_TXE_INTVL: interval in seconds. Specifies the periodic
> + * interval in which %NL80211_ATTR_CQM_TXE_PKTS and
> + * %NL80211_ATTR_CQM_TXE_RATE must be satisfied before generating an
> + * %NL80211_CMD_NOTIFY_CQM.
Should there be some ... sanity checking? Like ... can't set it to more
than, say, half an hour?
> + } else if (attrs[NL80211_ATTR_CQM_TXE_RATE] &&
> + attrs[NL80211_ATTR_CQM_TXE_PKTS] &&
> + attrs[NL80211_ATTR_CQM_TXE_INTVL]) {
> + u32 rate, pkts, intvl;
> + rate = nla_get_u32(attrs[NL80211_ATTR_CQM_TXE_RATE]);
> + pkts = nla_get_u32(attrs[NL80211_ATTR_CQM_TXE_PKTS]);
> + intvl = nla_get_u32(attrs[NL80211_ATTR_CQM_TXE_INTVL]);
> + err = nl80211_set_cqm_txe(info, rate, pkts, intvl);
You should probably check things here ... e.g. the percentage can't be
>100? :-)
Also it seems like there should be some way to *disable* it again that
you should document?
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
