On Tue, Jul 10, 2012 at 12:59:12PM +0300, Veli-Pekka Peltola wrote: > On 07/09/2012 03:41 PM, Stanislaw Gruszka wrote: > >Fix indention and remove unnecessary brackets and compares. > > Hi, > > Otherwise looks ok but I have a one comment, see below. > > >Signed-off-by: Stanislaw Gruszka <sgruszka@xxxxxxxxxx> > >--- > > drivers/net/wireless/rt2x00/rt2800pci.c | 11 +++++------ > > 1 files changed, 5 insertions(+), 6 deletions(-) > > > >diff --git a/drivers/net/wireless/rt2x00/rt2800pci.c b/drivers/net/wireless/rt2x00/rt2800pci.c > >index dd43612..bf0e71e 100644 > >--- a/drivers/net/wireless/rt2x00/rt2800pci.c > >+++ b/drivers/net/wireless/rt2x00/rt2800pci.c > > <snip> > > >@@ -1022,9 +1022,8 @@ static int rt2800_enable_wlan_rt3290(struct rt2x00_dev *rt2x00dev) > > rt2800_register_write(rt2x00dev, 0x58, 0x618); > > udelay(REGISTER_BUSY_DELAY); > > count++; > >- } else { > >+ } else > > count = 0; > >- } > > I have understood that Linux CodingStyle requires braces on all > else/if branches if any of those have more than one statement. So I > would not remove braces here. I'll just drop that hunk... -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html