On 07/11/2012 10:23 PM, Thomas Pedersen wrote: > The ath6kl firmware can monitor a connection and report when a certain > TX failure threshold is crossed. Support this configuration and event > reporting on compatible firmwares. > > Signed-off-by: Thomas Pedersen <c_tpeder@xxxxxxxxxxxxxxxx> [...] > + ev = (struct wmi_txe_notify_event *) datap; > + rate = le32_to_cpu(ev->rate); > + pkts = le32_to_cpu(ev->pkts); > + ath6kl_dbg(ATH6KL_DBG_WMI, "TXE notify event: peer %pM rate %d pkts %d\n", > + vif->bssid, rate, pkts); Empty line before the ath6kl_dbg() call, please. > +int ath6kl_wmi_set_txe_notify(struct wmi *wmi, u8 idx, > + u32 rate, u32 pkts, u32 intvl) > +{ > + struct sk_buff *skb; > + struct wmi_txe_notify_cmd *cmd; > + > + skb = ath6kl_wmi_get_new_buf(sizeof(*cmd)); > + if (!skb) > + return -ENOMEM; > + > + cmd = (struct wmi_txe_notify_cmd *) skb->data; > + cmd->rate = rate; > + cmd->pkts = pkts; > + cmd->intvl = intvl; cpu_to_le32()? > +/* WMI_SET_TXE_NOTIFY_CMD */ > +struct wmi_txe_notify_cmd { > + u32 rate; > + u32 pkts; > + u32 intvl; > +} __packed; > + > +/* WMI_TXE_NOTIFY_EVENTID */ > +struct wmi_txe_notify_event { > + u32 rate; > + u32 pkts; > +} __packed; Endian annotation? Kalle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html