On Fri, 2012-07-06 at 15:20 -0700, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx>
>
> Cellular base stations can provide hints to cfg80211 about
> where they think we are. This can be done for example by on
> a cell phone.
by what? :)
> To enable these hints we simply allow them
> through as user regulatory hints but we allow userspace
> to clasify the hint. This option is only available for
if you're going to respin ... classify
> system integrators which are willing to enable
who are willing? not sure
> CONFIG_CFG80211_CERTIFICATION_ONUS.
>
> The base station hints themselves will not be processsed
processed :)
> by the core unless at least one device on the system
> supports this feature.
So ... yeah I guess this is fine. we don't really want to distinguish
between the devices too much anyway. And I suspect that if you're in an
environment where you allow plugging in random wireless devices you
wouldn't enable this anyway.
> * DFS master operation on a known DFS region (NL80211_DFS_*),
> * dfs_region represents that region. Drivers can use this and the
> * @alpha2 to adjust their device's DFS parameters as required.
> + * @user_reg_hint_type: if the @initiator was of type
> + * %NL80211_REGDOM_SET_BY_USER, this clasifies the type
classifies
> + * of hint passed. This could be any of the %NL80211_USER_REG_HINT_*
could be any of the ... "values"?
> /* set up regulatory info */
> + wiphy_regulatory_register(wiphy);
> regulatory_update(wiphy, NL80211_REGDOM_SET_BY_CORE);
might make sense to move the regulatory_update() call into the new
function, then it could become a static function?
> +++ b/net/wireless/nl80211.c
> @@ -294,6 +294,7 @@ static const struct nla_policy nl80211_policy[NL80211_ATTR_MAX+1] = {
> [NL80211_ATTR_NOACK_MAP] = { .type = NLA_U16 },
> [NL80211_ATTR_INACTIVITY_TIMEOUT] = { .type = NLA_U16 },
> [NL80211_ATTR_BG_SCAN_PERIOD] = { .type = NLA_U16 },
> + [NL80211_ATTR_USER_REG_HINT_TYPE] = { .type = NLA_U8 },
I think u32 makes more sense, u8 doesn't actually save you anything
(same space in the netlink attributes, and you have to validate it
anyway)
> - r = regulatory_hint_user(data);
> + if (info->attrs[NL80211_ATTR_USER_REG_HINT_TYPE])
> + user_reg_hint_type =
> + nla_get_u8(info->attrs[NL80211_ATTR_USER_REG_HINT_TYPE]);
need to validate that it's a valid value, otherwise I can pass "42" :-)
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
