Search Linux Wireless

Re: [PATCH v2] brcmsmac: restructure info->control.sta handling as it is goning to be removed soon.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/10/2012 12:11 AM, Thomas Huehn wrote:
> Hi Arend,
> 
>>> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
>>> index 01b190a..d341c91 100644
>>> --- a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
>>> +++ b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
>>> @@ -665,7 +665,7 @@ brcms_c_sendampdu(struct ampdu_info *ampdu, struct brcms_txq_info *qi,
>>>  			u8 plcp0, plcp3, is40, sgi;
>>>  			struct ieee80211_sta *sta;
>>>  
>>> -			sta = tx_info->control.sta;
>>> +			sta = tx_info->rate_driver_data[0];
>>
>> The sta pointer is not used in this function so this assignment is not
>> needed. Also the rate_driver_data[0] does not yet hold the sta pointer
>> upon reaching this function. brcms_c_sendampdu is called from
>> brcms_c_sendpkt_mac80211 (see below).
>>
>> Just remove the sta pointer here.
> 
> 
> Good catch ! v2 is already sent.
> 

Given the subject of this one, I suspect it should have been v3. Hope
John can keep them apart.

Gr. AvS



--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux