On Tue, Jul 3, 2012 at 9:47 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Tue, 2012-07-03 at 09:28 -0700, Joe Perches wrote: >> On Tue, 2012-07-03 at 18:21 +0200, Johannes Berg wrote: >> > On Tue, 2012-07-03 at 09:16 -0700, Luis R. Rodriguez wrote: >> > > On Tue, Jul 3, 2012 at 8:47 AM, Luis R. Rodriguez <mcgrof@xxxxxxxxx> wrote: >> > > > On Tue, Jul 3, 2012 at 6:28 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: >> > > >> From: Johannes Berg <johannes.berg@xxxxxxxxx> >> > > >> >> > > >> As compat includes linux/device.h well before iwlwifi, the >> > > >> definitions from there are used without DEBUG, but iwlwifi >> > > >> defines DEBUG to get debug output. Use dev_printk instead >> > > >> of dev_dbg to get debugging back. >> > > >> >> > > >> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> >> > > > >> > > > Applied and pushed, thanks! >> > > >> > > On today's linux-next.git the dev_dbg() changed to dev_err(), I've >> > > updated the patch to reflect this. >> > >> > Huh, sorry. Please drop this for now -- the patch to change it *from* >> > dev_err *to* dev_dbg is only in my iwlwifi-next tree now. >> >> And besides, the concept is wrong. >> >> There's no reason to drop dynamic_debug support by >> forcing output to KERN_DEBUG. > > Well, the thing is, "#define DEBUG" doesn't work in compat-wireless ... > We add it to the Makefile though I guess What if we add a hunk to iwlwifi to undef DEBUG and redefine it ? Sort of similar problem as with pr_fmt no? I've merged this patch now. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
