On Mon, Jul 9, 2012 at 7:59 PM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2012-07-09 at 19:57 +0300, Arik Nemtsov wrote: >> The function building probe-request IEs does not validate the band is >> supported before dereferencing it. This can result in a panic when >> all bands are traversed, as done during sched-scan start. >> >> Warn when this happens and return an empty probe request. Also fix >> sched-scan to not waste memory on unsupported bands. >> >> Signed-off-by: Arik Nemtsov <arik@xxxxxxxxxx> >> --- >> better? :) > > Yeah I'll apply this :-) > > I do wonder though why we even bother building probe request IEs for a > band if no channels from it are listed in the sched scan request. It's a bit complicated to know this, because of how the request is structured (have to traverse all the channels etc). The memory waste is not so bad anyway I guess. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
