Rajkumar Manoharan wrote:
> Once the hw reset work is queued up and to bail out current
> execution properly, use HW_RESET bit ops instead of work_pending.
> As work_pending might return false when the queued work is in
> execution. So it is not correct to use the work utility for
> baining out.
I have one comment, though.
> diff --git a/drivers/net/wireless/ath/ath9k/beacon.c b/drivers/net/wireless/ath/ath9k/beacon.c
> index 40775da..567a655 100644
> --- a/drivers/net/wireless/ath/ath9k/beacon.c
> +++ b/drivers/net/wireless/ath/ath9k/beacon.c
> @@ -362,7 +362,7 @@ void ath_beacon_tasklet(unsigned long data)
> int slot;
> u32 bfaddr, bc = 0;
>
> - if (work_pending(&sc->hw_reset_work)) {
> + if (test_bit(SC_OP_HW_RESET, &sc->sc_flags)) {
This is not needed, since we bail out in ath_isr().
(And interrupts are re-enabled only at the end of ath9k_tasklet()).
Sujith
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
