Search Linux Wireless

Re: [PATCH] nl/cfg/mac80211: add set_mcast_rate API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 08, 2012 at 11:56:26AM +0200, Johannes Berg wrote:
> On Sun, 2012-07-08 at 11:31 +0200, Antonio Quartulli wrote:
> 
> > +int cfg80211_set_mcast_rate(struct cfg80211_registered_device *rdev,
> > +			    struct net_device *dev,
> > +			    struct cfg80211_ibss_params *params)
> 
> I'd say just inline the function into the nl80211.c handler itself, not
> much value in having it separate.

ok, will do.

> 
> 
> > +	mcast_attr = nla_get_u32(info->attrs[NL80211_ATTR_MCAST_RATE]);
> > +	if (info->attrs[NL80211_ATTR_MCAST_RATE] &&
> 
> this is wrong

ops, you are right! I moved the nla_get_u32() at the line before to avoid having
a ugly statement, but I missed something :)

Thank you


-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

Attachment: pgpQaxXaMU7zH.pgp
Description: PGP signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux